Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Store #1

Merged
merged 18 commits into from
May 7, 2024
Merged

API Store #1

merged 18 commits into from
May 7, 2024

Conversation

nicodelatorre7
Copy link
Contributor

No description provided.

README.md Show resolved Hide resolved
src/package-index.js Show resolved Hide resolved
defaultCount = clockCount || 10;
}

export { getAPIFn, defaultCount };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que sería mejor evitar los exports desperdigados en el archivo y definir al final

module.exports = { getAPIFn, defaultCount, initializeAPIStore, apiSaga };  // Esta última es necesario exportarla???

src/pages/DynamicDashboard/dashboard.js Show resolved Hide resolved
src/store/api/actionTypes.js Show resolved Hide resolved
src/store/api/saga.js Outdated Show resolved Hide resolved
src/store/api/saga.js Show resolved Hide resolved
import { getAPI } from "../helpers/apiRegistry";

const clockCount = 15;
initializeAPIStore({ getAPI, clockCount });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo porqué esta llamada al initializeAPIStore está acá...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esta dentro del paquete, es de la mini app que esta de ejemplo para probar el store

src/utils/helpers/api_calls.js Show resolved Hide resolved
src/utils/helpers/api_calls.js Show resolved Hide resolved
@nicodelatorre7 nicodelatorre7 merged commit c8e5ef8 into main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants